REOPENED 270699
[JSC] Add arbitrary label alignment functionality to offlineasm 
https://bugs.webkit.org/show_bug.cgi?id=270699
Summary [JSC] Add arbitrary label alignment functionality to offlineasm
Max Rottenkolber
Reported 2024-03-08 07:30:20 PST
To express some programs like the InPlaceInterpreter we need to align instructions to specific boundaries (such as 256). We currently to do this via `emit ".balign 256, 0xcc"' (for instance) but this is not reliable on armv7 as its globaladdr implementation can insert code unpredictably (from the point of view of the offlineasm user), hence breaking the alignment. We should add functionality in offlineasm to address this usecase reliably. Possibly related to rdar://113594783
Attachments
Add attachment proposed patch, testcase, etc.
EWS
Comment 1 2024-03-14 06:01:23 PDT
Committed 276085@main (71f803e6ee62): <https://commits.webkit.org/276085@main> Reviewed commits have been landed. Closing PR #25628 and removing active labels.
Radar WebKit Bug Importer
Comment 2 2024-03-14 06:02:15 PDT
<rdar://problem/124613758>
WebKit Commit Bot
Comment 3 2024-03-15 10:41:36 PDT
Re-opened since this is blocked by bug 271065
Mark Lam
Comment 4 2024-04-04 17:43:04 PDT
rdar://113594783
Mark Lam
Comment 5 2024-04-04 17:44:00 PDT
*** Bug 272200 has been marked as a duplicate of this bug. ***
Mark Lam
Comment 6 2024-04-04 17:47:40 PDT
Pull request for re-land: https://github.com/WebKit/WebKit/pull/26877
EWS
Comment 7 2024-04-05 13:15:43 PDT
Committed 277134@main (75713dba1787): <https://commits.webkit.org/277134@main> Reviewed commits have been landed. Closing PR #26877 and removing active labels.
EWS
Comment 8 2024-04-08 13:27:18 PDT
Committed 277212@main (885441cde700): <https://commits.webkit.org/277212@main> Reviewed commits have been landed. Closing PR #26986 and removing active labels.
Mark Lam
Comment 9 2024-04-08 13:33:38 PDT
We're going to revert this because it's causing crashes.
Mark Lam
Comment 10 2024-04-08 13:45:46 PDT
This was reverted by Justin Michaud in https://commits.webkit.org/277212@main.
Note You need to log in before you can comment on or make changes to this bug.