NEW 270654
Fix rendering of user-select: none selections 
https://bugs.webkit.org/show_bug.cgi?id=270654
Summary Fix rendering of user-select: none selections
Ahmad Saleem
Reported 2024-03-07 11:49:46 PST
Hi Team, While going through Blink's Commit, I came across another case, where Firefox Nightly 125 and Safari Technology Preview 190 are matching each other while Chrome Canary 124 does not. Test Case: https://jsfiddle.net/uLynz4jf/show ^ Middle container does not have 'selection' Blink Commit: https://chromium.googlesource.com/chromium/blink/+/541acdb58dd213a9998aba273d9bf8b71ac8c952 WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/rendering/TextPaintStyle.cpp#144 If I change to following, we do start matching with Chrome Canary 124: if (foreground.isValid() && foreground != selectionPaintStyle.fillColor && foreground != Color::transparentBlack) __ Just wanted to raise to get input and see whether we should match Chrome or not. @Alan - any input? Thanks!
Attachments
Reference Image (across Browsers) (353.67 KB, image/png)
2024-03-07 13:06 PST, Ahmad Saleem 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2024-03-07 13:06:37 PST
Created attachment 470233 [details] Reference Image (across Browsers) It is reference across Firefox Nightly 125, Chrome Canary 124, Safari 17.4 and patched browser.
Ahmad Saleem
Comment 2 2024-03-07 13:17:59 PST
NOTE - We already have this test imported: LayoutTests/imported/blink/fast/css/user-select-none.html --> Without the patch and somehow we are passing this test as well. Have already tried Private Browsing and disabling all extensions on my side. It is not reproducible for Alan (on Slack 1-1) with Safari 17.4.
Radar WebKit Bug Importer
Comment 3 2024-03-14 12:50:13 PDT
<rdar://problem/124633555>
Note You need to log in before you can comment on or make changes to this bug.