Bug 27064 - Turn off non-portable date manipulations for SYMBIAN (as well)
Summary: Turn off non-portable date manipulations for SYMBIAN (as well)
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 27065
  Show dependency treegraph
Reported: 2009-07-07 20:17 PDT by Laszlo Gombos
Modified: 2009-07-15 07:18 PDT (History)
4 users (show)

See Also:

Proposed fix. (3.56 KB, patch)
2009-07-07 20:31 PDT, Laszlo Gombos
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-07-07 20:17:17 PDT
The timegm() function and the tm_gmtoff and tm_zone fields are extensions to the ISO and POSIX standards; these are not available on WIN and some other UNIX-like systems (SOLARIS, SYMBIAN).

The rules to turn off these non-portable dependencies are repeated several times in wtf/DateMath.*. Perhaps we should introduce HAVE_XXX guards for these non-portable dependencies and place the rules in one single location.
Comment 1 Laszlo Gombos 2009-07-07 20:31:25 PDT
Created attachment 32425 [details]
Proposed fix.
Comment 2 David Kilzer (:ddkilzer) 2009-07-14 09:21:56 PDT
Comment on attachment 32425 [details]
Proposed fix.

Nice.  r=me
Comment 3 Simon Hausmann 2009-07-15 07:18:49 PDT
Nice, landed in r45908