RESOLVED FIXED 270595
Web Inspector: FolderizedTreeElement doesn't need to remember expansion states anymore since FolderTreeElement already does the job
https://bugs.webkit.org/show_bug.cgi?id=270595
Summary Web Inspector: FolderizedTreeElement doesn't need to remember expansion state...
Qianlang Chen
Reported 2024-03-06 12:50:17 PST
In the inspector's frontend, the FolderizedTreeElement component currently has the duty of listening to its child FolderTreeElement's change of expanded state and recording that with a local WI.Setting. (See https://github.com/WebKit/WebKit/blob/c31beeb0aa293d11b9d23a4c6f2f70cfda461dbe/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js#L310-L318) The PR https://github.com/WebKit/WebKit/pull/25370 adds this recording functionality to FolderTreeElement directly, which is used in a few more places in the inspector's frontend (like in the Storage tab). So, FolderizedTreeElement no longer needs to have that duty anymore, and all it needs to do is pass the id of the tree element to its child FolderTreeElement to let it do the recording job.
Attachments
Radar WebKit Bug Importer
Comment 1 2024-03-06 12:50:45 PST
EWS
Comment 2 2024-03-19 11:29:10 PDT
Committed 276357@main (3cc63f452ee1): <https://commits.webkit.org/276357@main> Reviewed commits have been landed. Closing PR #26080 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.