Bug 270592 - Profile allocations and track allocation mode in libPAS
Summary: Profile allocations and track allocation mode in libPAS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Degazio
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-06 12:48 PST by David Degazio
Modified: 2024-03-22 13:29 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Degazio 2024-03-06 12:48:12 PST 
rdar://122419407

We already have hooks at the bmalloc/WTF level to profile allocations, and categorize these allocations via compactible (can be referenced by a compact pointer) and a variety of non-compactible (e.g. JSCell, non-JSCell, in-Gigacage, etc) discriminators. Up until now we haven't added much profiling to allocation sites in libPAS, where the bulk of the allocation logic occurs, but it seems useful to be able to not only measure the amount of times we fastMalloc something, but also whether it hits the fast or slow path of a libPAS local allocator, for example.
Comment 1 David Degazio 2024-03-06 14:25:45 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25551
Comment 2 EWS 2024-03-07 16:06:55 PST 
Committed 275812@main (ce0c25336f53): <https://commits.webkit.org/275812@main>

Reviewed commits have been landed. Closing PR #25551 and removing active labels.