Bug 27055 - Qualify include path with wtf
Summary: Qualify include path with wtf
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27065
  Show dependency treegraph
 
Reported: 2009-07-07 19:03 PDT by Norbert Leser
Modified: 2009-07-15 08:14 PDT (History)
4 users (show)

See Also:


Attachments
Code patch for Interpreter.h (952 bytes, patch)
2009-07-07 19:03 PDT, Norbert Leser
eric: review-
Details | Formatted Diff | Diff
Second try. (1.02 KB, patch)
2009-07-14 18:25 PDT, Laszlo Gombos
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Norbert Leser 2009-07-07 19:03:20 PDT
Created attachment 32415 [details]
Code patch for Interpreter.h

On Symbian platforms we encounter include ambiguities of HashMap.h file, which is already present in default location.

Since that header filename is very generic, it appears to be appropriate and saver to add a pathname qualifier "wtf/HashMap.h" to the include statement.
Comment 1 Darin Adler 2009-07-07 21:59:39 PDT
Comment on attachment 32415 [details]
Code patch for Interpreter.h

It's OK to change the include here to the normal style, but the normal style is to include <wtf/HashMap.h> and include in a separate paragraph.
Comment 2 Eric Seidel (no email) 2009-07-13 00:45:54 PDT
Comment on attachment 32415 [details]
Code patch for Interpreter.h

r- per Darin's comment.
Comment 3 Laszlo Gombos 2009-07-14 18:25:31 PDT
Created attachment 32756 [details]
Second try.

Updated the patch based on Darin's feedback (filling in for Norbert.)
Note that since this patch reverses a subset of r44418 (presumably a build fix for WIN_CAIRO), the proposed fix might break WIN_CAIRO port (I CCd Brent on the bug).
Comment 4 Brent Fulgham 2009-07-14 20:20:08 PDT
This change should be fine for WIN_CAIRO.  I added the HashMap.h because it was needed to compile.  Using the fully-qualified wtf/HashMap.h path should not be a problem.
Comment 5 Simon Hausmann 2009-07-15 08:14:25 PDT
Landed in r45909