Bug 27053 - Ambiguity in LabelScope initialization
Summary: Ambiguity in LabelScope initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Emulator S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27065
  Show dependency tree / graph
 
Reported: 2009-07-07 18:52 PDT by Norbert Leser
Modified: 2009-07-13 01:20 PDT (History)
3 users (show)

See Also:

Attachments
Code patch for BytecodeGenerator.cpp (1.42 KB, patch)
2009-07-07 18:52 PDT, Norbert Leser 		ggaren: review+
Details | Formatted Diff | Diff
Updated patch for bug# 27053 (1.40 KB, patch)
2009-07-07 19:39 PDT, Norbert Leser 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Norbert Leser 2009-07-07 18:52:25 PDT 
Created attachment 32413 [details]
Code patch for BytecodeGenerator.cpp

Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve type of "0" unambiguously. Set expression explicitly to PassRefPtr<Label>::PassRefPtr().

Rather than implementing conditional block for COMPILER(WINSCW) it appears to be save and appropriate to modify the main-line code accordingly.
Comment 1 Geoffrey Garen 2009-07-07 19:09:16 PDT 
Comment on attachment 32413 [details]
Code patch for BytecodeGenerator.cpp

r=me

I think you can just write "PassRefPtr<Label>()" instead of "PassRefPtr<Label>::PassRefPtr()".
Comment 2 Norbert Leser 2009-07-07 19:39:23 PDT 
Created attachment 32424 [details]
Updated patch for bug# 27053

I just verified Geoffrey's suggestion about simplifying the statement, and he's right.

The updated patch contains the respective modification.
Comment 3 Eric Seidel (no email) 2009-07-10 23:14:20 PDT 
Comment on attachment 32424 [details]
Updated patch for bug# 27053

OK.  Your ChangeLog seems to have an extra return in it though.
Comment 4 Simon Hausmann 2009-07-13 01:20:40 PDT 
Landed in r45791. The ChangeLog was made from the wrong directory, btw. I moved it up to JavaScriptCore/ChangeLog and fixed the path.