Bug 27052 – Undef ASSERT, to avoid excessive warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Norbert Leser]

ASSERT will be defined in both conditional branches of the code following the proposed patch.
The explicit undef avoids potential warning messages during compilation.

[Norbert Leser]

Created attachment 32412 [details]
Code patch for Assertion.h

2nd attempt to add attachment - failed first time

[Eric Seidel (no email)]

I don't understand the reason for this patch?

[Laszlo Gombos]

Created attachment 32780 [details]
Second try.

Changed the patch so that it only impacts the SYMBIAN platform and reflect the intention of this change better. In addition fixed the ChangeLog (filling in for Norbert.)

The reason for this patch is to kill the following compiler warning:

"\WebKit\JavaScriptCore\wtf\Assertions.h", line 146: Warning:  #47-D: incompatible redefinition of macro "ASSERT" (declared at line 3029 of "\epoc32\include\e32def.h")
  #define ASSERT(assertion) ((void)0)

[Laszlo Gombos]

(In reply to comment #3)
> Created an attachment (id=32780) [details]
> Second try.
> 
> Changed the patch so that it only impacts the SYMBIAN platform and reflect the
> intention of this change better. In addition fixed the ChangeLog (filling in
> for Norbert.)
> 
> The reason for this patch is to kill the following compiler warning:
> 
> "\WebKit\JavaScriptCore\wtf\Assertions.h", line 146: Warning:  #47-D:
> incompatible redefinition of macro "ASSERT" (declared at line 3029 of
> "\epoc32\include\e32def.h")
>   #define ASSERT(assertion) ((void)0)

The second patch should obsolete the first patch from Norbert - I do not seems to have rights to make the first patch obsolete.

[Holger Freyther]

Comment on attachment 32412 [details]
Code patch for Assertion.h

Obsolete according to lazlos.

[Simon Hausmann]

Comment on attachment 32780 [details]
Second try.

r=me. I'll mention Symbian in the changelog when landing, to make it a bit clearer.

[Simon Hausmann]

Landed in r45907