Bug 270519 – `BaseAudioContext::currentSampleFrame` shows up in Crash Logs frequently

• Status: NEW
• Component: Media

[Ahmad Saleem]

Hi Team,

While looking into failures in LayoutTests on Debug (EWS link - https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Sonoma-Debug-WK2-Tests-EWS/a7688095-14221/fast/fixed-layout/fixed-layout-crash-log.txt) and this is not first time.

I noticed that:

2   0x282defad0 WebCore::BaseAudioContext::currentSampleFrame() const

^ this functions show-up frequently.

Here are two more places, where this happened:

bug 225247 (Comment 04) and bug 270477 as well.

__

Just wanted to raise so we can track and see why this shows-up in layout and other test cases (there might be legit case but - still confused, this showing up in 'Layout' fixed layout related crash log).

Thanks!

[Ahmad Saleem]

This is function definition: https://searchfox.org/wubkat/rev/bc31443b84ccca0f8fb615b8247c55f600b7dee1/Source/WebCore/Modules/webaudio/BaseAudioContext.h#116

size_t currentSampleFrame() const { return destination().currentSampleFrame(); }

where 'destination()' is virtual:

virtual const AudioDestinationNode& destination() const = 0;

and 'currentSampleFrame()' is calling:

https://searchfox.org/wubkat/rev/bc31443b84ccca0f8fb615b8247c55f600b7dee1/Source/WebCore/Modules/webaudio/AudioDestinationNode.h#46

size_t currentSampleFrame() const { return m_currentSampleFrame; }

and where `m_currentSampleFrame` is:

std::atomic<size_t> m_currentSampleFrame { 0 };

[Alexey Proskuryakov]

I doubt this has anything to do with WebKit, would be way below us in CrashReporter or something even lower level.

Also, the function picked for this changes over time, it hasn't always been BaseAudioContext::currentSampleFrame.

[Ahmad Saleem]

(In reply to Alexey Proskuryakov from comment #2)
> I doubt this has anything to do with WebKit, would be way below us in
> CrashReporter or something even lower level.
> 
> Also, the function picked for this changes over time, it hasn't always been
> BaseAudioContext::currentSampleFrame.

Fair - I just noticed it quite few times, so I thought to raise it. Although if it is something below WebKit level, happy to close it with 'RESOLVED MOVED' or if nothing to do then as 'RESOLVED WONTFIX' as well.

[Radar WebKit Bug Importer]

<rdar://problem/124458224>