Bug 270499 – AX: NULL attributed string returned for text markers that contain unconnected nodes

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joshua Hoffman]

rdar://122451549

The changes to move AXSelectedTextMarkerRange off of the main thread resulted in an issue where unconnected nodes (for example, the static text of an <input type=text>) were not having their values updated with the input field. This means that when the selected text range of that input is queried, and it references the unconnected node, we return a null string since it is not up-to-date.

[Joshua Hoffman]

rdar://122451549

[Joshua Hoffman]

Created attachment 470172 [details]
Patch

[Tyler Wilcock]

Comment on attachment 470172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470172&action=review

> LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html:6
> +<input type="text" id="input1" value="Hello">

Can this just be id="input"? IMO, "input1" implies there's an input2 / input3 / etc.

> LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html:16
> +    let startMarker = root.startTextMarkerForTextMarkerRange(textMarkerRange);
> +    let endMarker = root.endTextMarkerForTextMarkerRange(textMarkerRange);
> +
> +    let startElement = root.accessibilityElementForTextMarker(startMarker);
> +    let endElement = root.accessibilityElementForTextMarker(endMarker);

Can these be const?

[Joshua Hoffman]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 470172 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=470172&action=review
> 
> > LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html:6
> > +<input type="text" id="input1" value="Hello">
> 
> Can this just be id="input"? IMO, "input1" implies there's an input2 /
> input3 / etc.
> 
> > LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html:16
> > +    let startMarker = root.startTextMarkerForTextMarkerRange(textMarkerRange);
> > +    let endMarker = root.endTextMarkerForTextMarkerRange(textMarkerRange);
> > +
> > +    let startElement = root.accessibilityElementForTextMarker(startMarker);
> > +    let endElement = root.accessibilityElementForTextMarker(endMarker);
> 
> Can these be const?

Yes! I'll address both of these comments when I re-upload.

[Joshua Hoffman]

Created attachment 470176 [details]
Patch

[Alexey Proskuryakov]

*** Bug 270498 has been marked as a duplicate of this bug. ***

[EWS]

Committed 275694@main (a8f281f89e75): <https://commits.webkit.org/275694@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 470176 [details].