Bug 27047 - Sometimes the media controller remaining time disappear.
Summary: Sometimes the media controller remaining time disappear.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Pierre d'Herbemont
URL: http://iphone.akamai.com
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-07-07 16:12 PDT by Pierre d'Herbemont
Modified: 2009-07-07 18:28 PDT (History)
0 users

See Also:


Attachments
patch v1. (17.77 KB, patch)
2009-07-07 18:02 PDT, Pierre d'Herbemont
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre d'Herbemont 2009-07-07 16:12:51 PDT
Sometimes the media controller remaining time disappear.

- Go to http://iphone.akamai.com
- Click and load a video
- Load an other video
-> Remaining and Elapsed time text field are gone

<rdar://problem/7036201>
Comment 1 Pierre d'Herbemont 2009-07-07 18:02:34 PDT
Created attachment 32407 [details]
patch v1.
Comment 2 Simon Fraser (smfr) 2009-07-07 18:13:35 PDT
Comment on attachment 32407 [details]
patch v1.

> +2009-07-07  Pierre d'Herbemont  <pdherbemont@apple.com>
> +
> +        (WebCore::MediaControlElement::styleForElement): Shortcut.

Utility method, or "code factoring" would be a better description.

> diff --git a/WebCore/rendering/MediaControlElements.cpp b/WebCore/rendering/MediaControlElements.cpp

> +        return NULL;

WebCore code uses 0 instead of NULL.
Comment 3 Pierre d'Herbemont 2009-07-07 18:28:11 PDT
http://trac.webkit.org/changeset/45614