Bug 270454 - activeTab extension has access to page after turning the extension off, then back on
Summary: activeTab extension has access to page after turning the extension off, then ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Extensions (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-04 09:57 PST by Timothy Hatcher
Modified: 2024-03-04 14:02 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2024-03-04 09:57:15 PST 
We keep the temporaryPermissionMatchPattern on the WebExtensionTab object, and that is what needs cleared for activeTab. We should just open windows and tabs in WebExtensionContext::unload, they get repopulated in load() and repopulating will give everything a fresh window / tab ID.
Comment 1 Radar WebKit Bug Importer 2024-03-04 10:07:08 PST 
<rdar://problem/124016968>
Comment 2 Brian Weinstein 2024-03-04 12:06:30 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25441
Comment 3 EWS 2024-03-04 14:01:59 PST 
Committed 275651@main (7b1151eb7248): <https://commits.webkit.org/275651@main>

Reviewed commits have been landed. Closing PR #25441 and removing active labels.