Bug 270426 - import-w3c-tests should rewrite reference file names in fuzzy annotation
Summary: import-w3c-tests should rewrite reference file names in fuzzy annotation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks: 270427
  Show dependency tree / graph
 
Reported: 2024-03-03 18:37 PST by Matt Woodrow
Modified: 2024-03-06 11:13 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2024-03-03 18:37:55 PST 
The <meta> fuzzy tag supports passing the name of the reference file for which it should be applied (for situations where there could be multiple references, I believe).

Our harness does take this into account, and only uses the fuzzy expectation if the reference filename matches, but we don't rewrite '-ref' to '-expected', so it never matches.

It would be nice if we did this, and converted existing imported tests.
Comment 1 Radar WebKit Bug Importer 2024-03-04 14:50:27 PST 
<rdar://problem/124034791>
Comment 2 Matt Woodrow 2024-03-04 14:52:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25456
Comment 3 Matt Woodrow 2024-03-04 16:18:51 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25462
Comment 4 EWS 2024-03-06 11:13:21 PST 
Committed 275750@main (525f853875c0): <https://commits.webkit.org/275750@main>

Reviewed commits have been landed. Closing PR #25462 and removing active labels.