Bug 27037 - Fix baselines for inline tables.
Summary: Fix baselines for inline tables.
Status: RESOLVED DUPLICATE of bug 84167
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-07 12:38 PDT by Adam Langley
Modified: 2012-06-14 16:17 PDT (History)
5 users (show)

See Also:


Attachments
patch (3.65 KB, patch)
2009-07-07 12:42 PDT, Adam Langley
abarth: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-07-07 12:38:47 PDT
CSS specifies that the baseline of an inline table is the baseline of
the first row. Previously, inline tables were floating off into
nowhere.

See http://www.w3.org/TR/CSS2/visudet.html#leading:
  "The baseline of an 'inline-table' is the baseline of the first row of the table."
Comment 1 Adam Langley 2009-07-07 12:42:23 PDT
Created attachment 32388 [details]
patch

I'm not sure that the patch fixes this in the right way. The layout test included certainly demonstrates the issue and the patch fixes that, but it seems to cause some layout test failures which I'm still looking at.
Comment 2 Eric Seidel (no email) 2009-07-07 15:52:25 PDT
This is hyatt's area.  Possibly Adele too.
Comment 3 Eric Seidel (no email) 2009-07-15 16:10:57 PDT
Comment on attachment 32388 [details]
patch

Haven't heard much from the table folks.  But this looks sane to me.

Please fix your style error:
+int RenderTable::baselinePosition(bool firstLine, bool isRootLineBox) const {
+    if (firstBody() && style()->display() == INLINE_TABLE)

Make sure you've run the layout tests when landing.
Comment 4 Adam Barth 2009-07-16 15:53:37 PDT
Will land.
Comment 5 Adam Barth 2009-07-16 16:09:20 PDT
Comment on attachment 32388 [details]
patch

This patch fails the following tests:

editing/pasteboard/innerText-inline-table.html
editing/selection/iframe.html
editing/selection/inline-table.html
editing/selection/table-caret-3.html
fast/css-generated-content/inline-display-types.html
fast/encoding/utf-16-big-endian.html
fast/encoding/utf-16-little-endian.html
fast/inline-block/001.html
fast/invalid/residual-style.html
fast/repaint/float-overflow-right.html
fast/repaint/float-overflow.html
http/tests/misc/redirect-to-about-blank.html
tables/mozilla/bugs/bug2479-2.html
Comment 6 Adam Barth 2009-07-16 16:16:01 PDT
Unassigning.  This is no longer actionable by me.
Comment 7 Adam Langley 2009-07-16 18:36:25 PDT
Sorry, I didn't intend for anyone to land this patch just yet. It does 'fail' tests, but I believe that the baselines are currently wrong for those tests.

I don't have time to look at this now, so I'll leave the patch r-'ed.
Comment 8 Julien Chaffraix 2012-06-14 16:17:53 PDT
This was solved by Robert as part of bug 84167. Duplicating this bug as the other bug had a fix that landed. I believe Robert's coverage was enough to cover the test in this patch.

*** This bug has been marked as a duplicate of bug 84167 ***