Bug 27037 – Fix baselines for inline tables.

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[Adam Langley]

CSS specifies that the baseline of an inline table is the baseline of
the first row. Previously, inline tables were floating off into
nowhere.

See http://www.w3.org/TR/CSS2/visudet.html#leading:
  "The baseline of an 'inline-table' is the baseline of the first row of the table."

[Adam Langley]

Created attachment 32388 [details]
patch

I'm not sure that the patch fixes this in the right way. The layout test included certainly demonstrates the issue and the patch fixes that, but it seems to cause some layout test failures which I'm still looking at.

[Eric Seidel (no email)]

This is hyatt's area.  Possibly Adele too.

[Eric Seidel (no email)]

Comment on attachment 32388 [details]
patch

Haven't heard much from the table folks.  But this looks sane to me.

Please fix your style error:
+int RenderTable::baselinePosition(bool firstLine, bool isRootLineBox) const {
+    if (firstBody() && style()->display() == INLINE_TABLE)

Make sure you've run the layout tests when landing.

[Adam Barth]

Will land.

[Adam Barth]

Comment on attachment 32388 [details]
patch

This patch fails the following tests:

editing/pasteboard/innerText-inline-table.html
editing/selection/iframe.html
editing/selection/inline-table.html
editing/selection/table-caret-3.html
fast/css-generated-content/inline-display-types.html
fast/encoding/utf-16-big-endian.html
fast/encoding/utf-16-little-endian.html
fast/inline-block/001.html
fast/invalid/residual-style.html
fast/repaint/float-overflow-right.html
fast/repaint/float-overflow.html
http/tests/misc/redirect-to-about-blank.html
tables/mozilla/bugs/bug2479-2.html

[Adam Barth]

Unassigning.  This is no longer actionable by me.

[Adam Langley]

Sorry, I didn't intend for anyone to land this patch just yet. It does 'fail' tests, but I believe that the baselines are currently wrong for those tests.

I don't have time to look at this now, so I'll leave the patch r-'ed.

[Julien Chaffraix]

This was solved by Robert as part of bug 84167. Duplicating this bug as the other bug had a fix that landed. I believe Robert's coverage was enough to cover the test in this patch.

*** This bug has been marked as a duplicate of bug 84167 ***