Bug 27035 - [Chromium] Upstream DOMObjectsInclude.h
Summary: [Chromium] Upstream DOMObjectsInclude.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-07 11:05 PDT by Nate Chapin
Modified: 2009-07-07 14:23 PDT (History)
0 users

See Also:


Attachments
patch (7.16 KB, patch)
2009-07-07 11:09 PDT, Nate Chapin
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2009-07-07 11:05:26 PDT
See summary.
Comment 1 Nate Chapin 2009-07-07 11:09:25 PDT
Created attachment 32387 [details]
patch
Comment 2 Darin Fisher (:fishd, Google) 2009-07-07 13:18:50 PDT
Comment on attachment 32387 [details]
patch

> Index: WebCore/bindings/v8/DOMObjectsInclude.h

> + * this software without specific prior written permission.
> + * 

^^^ looks like there is an extra space at the end of that line.


> +#if ENABLE(DOM_STORAGE)
> +#include "Storage.h"
> +#include "StorageEvent.h"
> +#endif

^^^ should that have a "// STORAGE" comment like the others?


otherwise, R=me
Comment 3 Nate Chapin 2009-07-07 14:23:30 PDT
Landed at r45605.  Thanks!