Bug 270348 – export-w3c-test-changes should allow the branch to be kept on failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sam Sneddon [:gsnedders]]

see e.g.:

gsnedders@gsnedders-marsha OpenSource % ./Tools/Scripts/export-w3c-test-changes -d ~/projects/wpt/wpt2/web-platform-tests -u '[e-mail]:web-platform-tests/wpt.git' -g 6abbfb0
Fetching web-platform-tests repository
Cleaning web-platform-tests master branch
Applying patch to web-platform-tests branch wpt-export-for-webkit-0
WARNING: You are using pip version 21.2.4; however, version 24.0 is available.
You should consider upgrading via the '/Volumes/gsnedders/projects/wpt/wpt2/web-platform-tests/_venv3/bin/python3 -m pip install --upgrade pip' command.
ERROR:lint:css/css-text/letter-spacing/letter-spacing-percent-001.html: Reference test with a non-existent 'match' relationship reference: 'reference/letter-spacing-percent-001-ref.html' (NON-EXISTENT-REF)
ERROR:lint:css/css-text/word-spacing/word-spacing-percent-001.html: Reference test with a non-existent 'match' relationship reference: 'reference/word-spacing-percent-001-ref.html' (NON-EXISTENT-REF)
INFO:lint:
INFO:lint:There were 2 errors (NON-EXISTENT-REF: 2)
INFO:lint:You must fix all errors; for details on how to fix them, see
INFO:lint:https://web-platform-tests.org/writing-tests/lint-tool.html
INFO:lint:
INFO:lint:However, instead of fixing a particular error, it's sometimes
INFO:lint:OK to add a line to the lint.ignore file in the root of the
INFO:lint:web-platform-tests directory to make the lint tool ignore it.
INFO:lint:
INFO:lint:For example, to make the lint tool ignore all 'NON-EXISTENT-REF'
INFO:lint:errors in the css/css-text/word-spacing/word-spacing-percent-001.html file,
INFO:lint:you could add the following line to the lint.ignore file.
INFO:lint:
INFO:lint:NON-EXISTENT-REF: css/css-text/word-spacing/word-spacing-percent-001.html
ERROR: The wpt linter detected 2 linting error(s). Please address the above errors before attempting to export changes to the web-platform-test repository.
Removing local branch wpt-export-for-webkit-0
Cleaning web-platform-tests master branch

This doesn't give me any ability to attempt to resolve lint failures effectively caused by bug 186132 manually.

[Radar WebKit Bug Importer]

<rdar://problem/124269575>

[Sam Sneddon [:gsnedders]]

Pull request: https://github.com/WebKit/WebKit/pull/36219

[EWS]

Committed 286253@main (c85579a8aa15): <https://commits.webkit.org/286253@main>

Reviewed commits have been landed. Closing PR #36219 and removing active labels.