Bug 270325 - Add optimization in `handleStyleSpans()` to restrict 'for-loop' to iterate only over InsteredNodes
Summary: Add optimization in `handleStyleSpans()` to restrict 'for-loop' to iterate on...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-29 16:28 PST by Ahmad Saleem
Modified: 2024-06-24 05:07 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryosuke Niwa 2024-02-29 16:48:07 PST 
Seems okay to merge.
Comment 2 Radar WebKit Bug Importer 2024-03-07 16:29:14 PST 
<rdar://problem/124240436>
Comment 3 Ahmad Saleem 2024-06-24 05:07:33 PDT 
It seems that it is triggering crashes in following test cases:

editing/inserting/inset-html-textarea-without-renderer.html
editing/pasteboard/5761530-2.html
fast/editing/replace-selection-command-crash.html
media/video-replaces-poster.html

PR attempt - https://github.com/WebKit/WebKit/pull/25325

It might be something in relation to now use 'RefPtr' or use it with with more changes beside just this.

@Ryosuke - any thoughts? Or you wanna explore it?