WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
270321
Remove unnecessary copy when checking if a page is running an extension
https://bugs.webkit.org/show_bug.cgi?id=270321
Summary
Remove unnecessary copy when checking if a page is running an extension
Ben Nham
Reported
2024-02-29 14:23:52 PST
For every navigation decision, we check whether the associated page is running a web extension by calling `page.cocoaView().get().configuration._requiredWebExtensionBaseURL`. Since configuration is marked as a `copy` property, this causes an allocation and copy every time it's called. We should avoid the copy since it's not useful.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-02-29 14:24:26 PST
<
rdar://problem/123858678
>
Ben Nham
Comment 2
2024-02-29 14:25:27 PST
Pull request:
https://github.com/WebKit/WebKit/pull/25318
EWS
Comment 3
2024-02-29 22:16:49 PST
Committed
275538@main
(35745daf8d35): <
https://commits.webkit.org/275538@main
> Reviewed commits have been landed. Closing PR #25318 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug