Bug 270314 - [git-webkit pr] Should prompt user if radar and bugs do not match
Summary: [git-webkit pr] Should prompt user if radar and bugs do not match
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-29 12:55 PST by Brianna Fan
Modified: 2024-03-14 08:18 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brianna Fan 2024-02-29 12:55:57 PST 
When a mismatch is found, we currently print the warning but continue. We should raise an exception and catch it so that the user can take action if needed.
Comment 1 Radar WebKit Bug Importer 2024-02-29 12:56:22 PST 
<rdar://problem/123852726>
Comment 2 Brianna Fan 2024-02-29 13:04:18 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25313
Comment 3 EWS 2024-03-05 11:48:26 PST 
Committed 275703@main (839318cccbdf): <https://commits.webkit.org/275703@main>

Reviewed commits have been landed. Closing PR #25313 and removing active labels.
Comment 4 Brianna Fan 2024-03-06 12:35:35 PST 
Reopened Bugzilla.
testing git-webkit revert on radars, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=267969.
Comment 5 EWS 2024-03-14 08:18:45 PDT 
Committed 272448.727@safari-7618-branch (5b5803eb4127): <https://commits.webkit.org/272448.727@safari-7618-branch>

Reviewed commits have been landed. Closing PR #1127 and removing active labels.