Bug 27015 – CSS properties such as color: and font-size: may be applied applied to the Media Controller text.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Pierre d'Herbemont]

CSS properties such as color: and font-size: may be applied applied to the Media Controller text.

<rdar://problem/7027586>

[Pierre d'Herbemont]

Created attachment 32335 [details]
patch v1.

[Simon Fraser (smfr)]

Comment on attachment 32335 [details]
patch v1.

>     WebCore:
>     
>     2009-07-06  Pierre d'Herbemont  <[e-mail]>
>     
>             Reviewed by NOBODY (OOPS!).
>     
>             Make sure the media controller style is not overrided.

This is too vague, and not actually correct. You need to take care that your changelogs are very explicit about the changes being made, and that they make sense to someone who is not familiar with the code.

>     
>             This is only for QT mode. And this mostly affects text

What is QT mode (for someone not familiar)?

>             properties.
>     
>             There is a special case for text-decoration that can't
>             be overrided from CSS. In this case we just
>             force it from the code.

Where is the changelog file entry for this? In cases like this, it's good to annotate the individual file changes one by one.

I'm going to be a hard-ass and r- this to give you some changelog-writing practice.  :)

[Pierre d'Herbemont]

Created attachment 32345 [details]
patch v2.

hum. ChangeLog more descriptive this time :-)

[Pierre d'Herbemont]

Created attachment 32346 [details]
patch v3.

git changelog was still the old one for some reason.

[Pierre d'Herbemont]

http://trac.webkit.org/changeset/45601