Bug 270140 - [UnifiedPDF] Word selections should not be generated when clicking on annotations
Summary: [UnifiedPDF] Word selections should not be generated when clicking on annotat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abrar Rahman Protyasha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-26 19:43 PST by Abrar Rahman Protyasha
Modified: 2024-02-27 01:37 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2024-02-26 19:43:57 PST 
Sometimes we arbitrarily create a text selection when clicking on annotations (or even when just clicking around on the frame). This is a result of us overriding the current selection unnecessarily in UnifiedPDFPlugin::lookupTextAtLocation. Let's fix this.
Comment 1 Radar WebKit Bug Importer 2024-02-26 19:44:05 PST 
<rdar://problem/123666112>
Comment 2 Abrar Rahman Protyasha 2024-02-26 20:24:03 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25149
Comment 3 EWS 2024-02-27 01:37:48 PST 
Committed 275370@main (6e854117d8ef): <https://commits.webkit.org/275370@main>

Reviewed commits have been landed. Closing PR #25149 and removing active labels.