Bug 27013 - WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition for Windows
: WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition fo...
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-07-06 16:00 PST by
Modified: 2009-07-08 14:36 PST (History)


Attachments
patch (1.49 KB, patch)
2009-07-07 16:00 PST, Dumitru Daniliuc
fishd: review-
Review Patch | Details | Formatted Diff | Diff
patch (2.70 KB, patch)
2009-07-07 16:37 PST, Dumitru Daniliuc
fishd: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-07-06 16:00:47 PST
WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition for PLATFORM(WIN_OS).
------- Comment #1 From 2009-07-06 17:23:52 PST -------
What I wanted was a way to distinguish between the CHROMIUM port on Windows and the CHROMIUM port on Mac/Linux. If I understand the code correctly, there's no way to do this in WebKit, because WebKit knows only about one generic CHROMIUM port. So we'll have to take care of this in the Chromium code.
------- Comment #2 From 2009-07-07 15:56:29 PST -------
After talking to Darin, it looks like we can extend the PlatformFileHandle definition for PLATFORM(WIN) to all WebKit ports built on Windows, which seems reasonable to me and works for Chromium too.

Reopening the issue, patch coming shortly.
------- Comment #3 From 2009-07-07 16:00:03 PST -------
Created an attachment (id=32399) [details]
patch
------- Comment #4 From 2009-07-07 16:28:13 PST -------
(From update of attachment 32399 [details])
I'm concerned this may cause problems for the PLATFORM(QT) build.
I believe that in the PLATFORM(QT) builds on Windows, PLATFORM(WIN_OS)
will also be defined.

You may be able to avoid that problem by revising the #ifdefs to check
for PLATFORM(QT) before checking for PLATFORM(WIN_OS).

Also, the very last PLATFORM(WIN) in FileSystem.h might be best kept
as PLATFORM(WIN).  It looks like it is a declaration of additional
functions that perhaps only make sense in the PLATFORM(WIN) port
(i.e., Safari on Windows).
------- Comment #5 From 2009-07-07 16:30:27 PST -------
CC'ing folks who seemed to have been involved with the PLATFORM(QT) code in FileSystem.h.  Guys, please see comment #4.  Thanks!
------- Comment #6 From 2009-07-07 16:37:30 PST -------
Created an attachment (id=32401) [details]
patch

done.
------- Comment #7 From 2009-07-07 17:07:38 PST -------
(From update of attachment 32401 [details])
This looks like it will work.  R=me
------- Comment #8 From 2009-07-08 14:36:24 PST -------
Landed as:  http://trac.webkit.org/changeset/45640