WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
270118
Replies from GPUConnection::Connection::sendWithAsyncReply will always be called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=270118
Summary
Replies from GPUConnection::Connection::sendWithAsyncReply will always be cal...
Jean-Yves Avenard [:jya]
Reported
2024-02-26 13:52:14 PST
When you send a message from the GPUConnection::connection()->sendWithAsyncReply (or sendWithPromisedReply), the reply will always be dispatched from the main thread. It can make for some surprising behaviour when a WorkQueueMessageReceiver expect an answer on its defined work queue.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-02-26 13:52:32 PST
<
rdar://problem/123650202
>
Jean-Yves Avenard [:jya]
Comment 2
2024-02-26 14:09:30 PST
A solution would be to have an override for `Connection::sendWithAsyncReply` that takes a SerialFunctionDispatcher on which the reply will be called on and pipe things internally to either dispatched the reply to Connection::dispatcher() or that defined SerialFunctionDispatcher.
Jean-Yves Avenard [:jya]
Comment 3
2024-02-27 04:28:04 PST
Pull request:
https://github.com/WebKit/WebKit/pull/25092
Jean-Yves Avenard [:jya]
Comment 4
2024-02-27 04:37:32 PST
Pull request:
https://github.com/WebKit/WebKit/pull/25166
EWS
Comment 5
2024-02-29 06:46:30 PST
Committed
275494@main
(cae00d824a49): <
https://commits.webkit.org/275494@main
> Reviewed commits have been landed. Closing PR #25166 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug