Bug 270047 - [Skia] Do not use the legacy native GL/EGL interface factory
Summary: [Skia] Do not use the legacy native GL/EGL interface factory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks: GLibSkia
  Show dependency tree / graph
 
Reported: 2024-02-25 02:28 PST by Adrian Perez
Modified: 2024-02-26 00:14 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2024-02-25 02:28:35 PST 
Skia is slowly transitioning away from the implicit instantiation of
its GL/EGL interface helpers via GrGLMakeNativeInterface(), which I have
been made aware of in a comment here:

  https://skia-review.googlesource.com/c/skia/+/814176/comment/dc3041af_dbaf1a16/

From the WebKit side what we need to do is explicitly passing a GrGLInterface
which we have explicitly created when using GrDirectContext::MakeGL()
Comment 1 Adrian Perez 2024-02-25 02:39:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25069
Comment 2 EWS 2024-02-26 00:13:32 PST 
Committed 275311@main (c6ffba680732): <https://commits.webkit.org/275311@main>

Reviewed commits have been landed. Closing PR #25069 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-02-26 00:14:15 PST 
<rdar://problem/123618141>