Bug 270034 - [MSE] Media from the TimeRange containing currentTime can be evicted when it shouldn't
Summary: [MSE] Media from the TimeRange containing currentTime can be evicted when it ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-24 00:48 PST by Jean-Yves Avenard [:jya]
Modified: 2024-02-25 21:27 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2024-02-24 00:48:25 PST 
In Bug 246144, an exception was added to not evict data from the time range that contains currentTime. [1]

// Do not evict data from the time range that contains currentTime.

But that is not what the code does. it just aborts if the current TimeRange contains the currentTime and there's no buffered range after that.


[1] https://searchfox.org/wubkat/rev/2a2bff6e7028e22ab05443ee79f7c742c0db8eeb/Source/WebCore/platform/graphics/SourceBufferPrivate.cpp#496-503
Comment 1 Radar WebKit Bug Importer 2024-02-24 04:10:28 PST 
<rdar://problem/123556056>
Comment 2 Jean-Yves Avenard [:jya] 2024-02-24 04:16:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25057
Comment 3 EWS 2024-02-25 21:27:45 PST 
Committed 275306@main (19f884773fca): <https://commits.webkit.org/275306@main>

Reviewed commits have been landed. Closing PR #25057 and removing active labels.