Bug 269919 – AX: Implement support for serving kAXLineForIndexParameterizedAttribute off the main-thread

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

...

[Radar WebKit Bug Importer]

<rdar://problem/123445635>

[Tyler Wilcock]

Created attachment 470014 [details]
Patch

[chris fleizach]

Comment on attachment 470014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470014&action=review

> Source/WebCore/accessibility/AXTextMarker.cpp:582
> +    // We need to check index + 1 markers to behave correctly, so increment before iterating.

is there a reason we need to increment here?

[Tyler Wilcock]

Created attachment 470047 [details]
Patch

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 470014 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=470014&action=review
> 
> > Source/WebCore/accessibility/AXTextMarker.cpp:582
> > +    // We need to check index + 1 markers to behave correctly, so increment before iterating.
> 
> is there a reason we need to increment here?
It's needed to match the existing VisiblePosition-based implementation of this logic. After your comment, I investigated more deeply and tried a few things to avoid it, but wasn't successful. I can remove it, but it would cause us to fail a few parts of the newly added test. I just uploaded a new patch with a better comment explaining why we do this -- I figure we can re-work it later if it turns out to be wrong in some other different edge case.

[EWS]

Committed 275325@main (39028c1e4999): <https://commits.webkit.org/275325@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 470047 [details].