RESOLVED CONFIGURATION CHANGED269880
New test (274810@main): [ macOS iOS ] 13 SVG tests are a consistent image failure 
https://bugs.webkit.org/show_bug.cgi?id=269880
Summary New test (274810@main): [ macOS iOS ] 13 SVG tests are a consistent image fai...
Karl Rackler
Reported 2024-02-21 16:51:51 PST
Description: imported/w3c/web-platform-tests/svg/painting/reftests/fallback-001.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-implicit-subpaths.html imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-021.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-022.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023.svg imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke.svg imported/w3c/web-platform-tests/svg/painting/reftests/markers-orient-002.svg imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-001.svg imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-002.svg The test was added at 274810@main and has been a consistent image failure since then. Looking at commit 274810@main, [ Failure ] was used instead of [ ImageOnlyFailure ], and that just needs to be changed for the tests expectations. History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Ffallback-001.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-path-003.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-path-011.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-path-012.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-path-013.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-path-021.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-path-022.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-path-023.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarker-units-strokewidth-non-scaling-stroke.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fmarkers-orient-002.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fpaint-context-001.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fpainting%2Freftests%2Fpaint-context-002.svg Image Diff: https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/fallback-001-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-implicit-subpaths-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-021-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-022-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/markers-orient-002-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-001-diffs.html https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Tests/274827@main%20(946)/imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-002-diffs.html
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-21 16:55:29 PST
<rdar://problem/123413079>
Ahmad Saleem
Comment 2 2024-02-21 16:56:41 PST
Happy to change to [ImageOnly Failure] but I will hold-off since Rob has patch to progress two of these tests. https://github.com/WebKit/WebKit/pull/24814
EWS
Comment 3 2024-02-21 17:18:06 PST
Test gardening commit 275139@main (9946d935760f): <https://commits.webkit.org/275139@main> Reviewed commits have been landed. Closing PR #24912 and removing active labels.
Karl Rackler
Comment 4 2024-02-21 17:21:21 PST
Reached out in Slack. Since this was causing the test runs to show these as imageonlyfailures I went ahead and landed the updated test expectations. We can always update and then push the fix for the other two. Thank you!
Note You need to log in before you can comment on or make changes to this bug.