Bug 269771 - AX: refactor downcast in setLastPresentedTextPrediction
Summary: AX: refactor downcast in setLastPresentedTextPrediction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joshua Hoffman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-19 21:07 PST by Joshua Hoffman
Modified: 2024-02-20 10:30 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2024-02-19 21:18 PST, Joshua Hoffman 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2024-02-19 21:36 PST, Joshua Hoffman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Hoffman 2024-02-19 21:07:26 PST 
To avoid duplicate work during downcasting, we should separate where we perform the dynamic downcast and where we dereference the pointer.
Comment 1 Radar WebKit Bug Importer 2024-02-19 21:07:33 PST 
<rdar://problem/123289610>
Comment 2 Joshua Hoffman 2024-02-19 21:18:43 PST 
Created attachment 469986 [details]
Patch
Comment 3 chris fleizach 2024-02-19 21:33:31 PST 
Comment on attachment 469986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469986&action=review

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:144
> +        auto nodeText = dynamicDowncast<Text>(previousCompositionNode);

Auto*
Comment 4 Joshua Hoffman 2024-02-19 21:36:58 PST 
Created attachment 469987 [details]
Patch
Comment 5 EWS 2024-02-20 10:30:41 PST 
Committed 275051@main (2f2435a780c4): <https://commits.webkit.org/275051@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 469987 [details].