Bug 269763 – Ensure cell's replaced content doesn't get the wrong width

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across another failing test case.

Test Case: https://jsfiddle.net/md6j97ar/show

Safari Technology Preview 188 and Firefox Nightly 125 also fails this test. Only Chrome Canary 123 is passing this.

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/03d66d9ce1e602df26a9d544d9258a88b9194349

WebKit Source: https://searchfox.org/wubkat/rev/74c0aa4209e14edf714b16d023ac838b718120f8/Source/WebCore/rendering/RenderTableCell.cpp#201

Below compiles and make us progress this test:

___

    // We don't want the preferred width from children to be affected by any
    // notional height on the cell, such as can happen when a percent sized image
    // scales up its width to match the available height. Setting a zero override
    // height prevents this from happening.
    LayoutUnit contentHeight = hasOverridingLogicalHeight() ? overridingLogicalHeight() : LayoutUnit(-1);

    if (contentHeight > -1)
        setOverridingLogicalHeight(LayoutUnit());
    RenderBlockFlow::computePreferredLogicalWidths();
    if (contentHeight > -1)
        setOverridingLogicalHeight(contentHeight);

___

Just wanted to raise so we can fix it. Please share any input.

Thanks!

[Ahmad Saleem]

Merge with - https://chromium.googlesource.com/chromium/src.git/+/b5243ab8c1a95305aff233a6175aa3a1f94d092f

[Karl Dubost]

Created attachment 469999 [details]
rendering in safari, firefox, chrome

None of the 4 browsers return the same results for the test.

Safari Technology Preview  188           19619.1.2.1.1
Firefox Nightly            125.0a1       12524.2.20
Google Chrome Canary       123.0.6312.2  6312.2

So there might be something deeper to explore here.

[Radar WebKit Bug Importer]

<rdar://problem/123658956>

[Ahmad Saleem]

std::optional<LayoutUnit> contentHeight = this->overridingLogicalHeight();
    if (contentHeight > -1)
        setOverridingLogicalHeight(0_lu);
    RenderBlockFlow::computePreferredLogicalWidths();
    if (contentHeight > -1)
        setOverridingLogicalHeight(*contentHeight);

[Ahmad Saleem]

Pull request: https://github.com/WebKit/WebKit/pull/38376

[EWS]

Committed 288316@main (0b242bd08948): <https://commits.webkit.org/288316@main>

Reviewed commits have been landed. Closing PR #38376 and removing active labels.