Bug 26976 - WebInspector: suggest global properties based on async evaluation.
Summary: WebInspector: suggest global properties based on async evaluation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-05 04:05 PDT by Pavel Feldman
Modified: 2009-07-06 13:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch with the fix (4.36 KB, patch)
2009-07-05 04:09 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff
Patch with the fix (4.45 KB, application/octet-stream)
2009-07-05 05:43 PDT, Pavel Feldman
no flags Details
Patch with the fix (4.45 KB, patch)
2009-07-05 05:46 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-07-05 04:05:36 PDT
At the moment, empty string was evaluated to the global object
(or scope chain objects) synchronously. This is not in line with 
the rest of the code and needs to be fixed for the real serialized
evaluation.
Comment 1 Pavel Feldman 2009-07-05 04:09:17 PDT
Created attachment 32271 [details]
Patch with the fix
Comment 2 Pavel Feldman 2009-07-05 05:43:42 PDT
Created attachment 32272 [details]
Patch with the fix
Comment 3 Pavel Feldman 2009-07-05 05:46:07 PDT
Created attachment 32273 [details]
Patch with the fix
Comment 4 Eric Seidel (no email) 2009-07-06 13:48:49 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/Console.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
Committed r45562