Bug 26966 - [V8] Move security functions from V8Proxy to V8SecurityManager
Summary: [V8] Move security functions from V8Proxy to V8SecurityManager
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-07-04 08:33 PDT by Adam Barth
Modified: 2009-08-19 19:19 PDT (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-07-04 08:33:31 PDT
My initial impression of which functions to move are:

        static DOMWindow* retrieveWindow();
        static DOMWindow* retrieveWindow(v8::Handle<v8::Context>);
        static V8Proxy* retrieve();
        static V8Proxy* retrieve(Frame*);
        static V8Proxy* retrieve(ScriptExecutionContext*);
        static Frame* retrieveFrame();
        static Frame* retrieveFrame(v8::Handle<v8::Context>);
        static Frame* retrieveFrameForEnteredContext();
        static Frame* retrieveFrameForCurrentContext();
        static Frame* retrieveFrameForCallingContext();
        static v8::Local<v8::Context> context(Frame*);
        static v8::Local<v8::Context> currentContext();
        static bool canAccessFrame(Frame*, bool reportError);
        static bool checkNodeSecurity(Node*);
        static bool canAccessPrivate(DOMWindow*);

I think there are some more hidden elsewhere.

Also, I would hope we can cut down on the number of retrieve* functions.  How is a developer supposed to know which one to use?