Bug 269622 - Fix the internal build with recent SDKs - InspectorBackendDispatcher::getPropertyValue() is a weak external symbol
Summary: Fix the internal build with recent SDKs - InspectorBackendDispatcher::getProp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abrar Rahman Protyasha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-16 15:57 PST by Abrar Rahman Protyasha
Modified: 2024-04-02 19:35 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2024-02-16 15:57:23 PST 
The build error:

```
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIbEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc
ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIdEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc
ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIiEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc
Command PhaseScriptExecution failed with a nonzero exit code
```
Comment 1 Radar WebKit Bug Importer 2024-02-16 15:57:30 PST 
<rdar://problem/123120005>
Comment 2 Radar WebKit Bug Importer 2024-02-16 16:07:40 PST 
<rdar://problem/123120550>
Comment 3 Abrar Rahman Protyasha 2024-02-16 16:14:26 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24667
Comment 4 EWS 2024-02-16 18:02:20 PST 
Committed 274901@main (790c37c321c3): <https://commits.webkit.org/274901@main>

Reviewed commits have been landed. Closing PR #24667 and removing active labels.
Comment 5 EWS 2024-04-02 19:35:28 PDT 
Committed 272448.857@safari-7618-branch (95d9ceea9e0c): <https://commits.webkit.org/272448.857@safari-7618-branch>

Reviewed commits have been landed. Closing PR #1169 and removing active labels.