Bug 26955 - Use RGBColor::create in V8 bindings codegenerator
Summary: Use RGBColor::create in V8 bindings codegenerator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Mads Ager
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-03 12:22 PDT by Mads Ager
Modified: 2009-07-17 00:43 PDT (History)
3 users (show)

See Also:

Attachments
Use RGBColor::create in V8 bindings codegen (5.57 KB, patch)
2009-07-03 12:22 PDT, Mads Ager 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Ager 2009-07-03 12:22:48 PDT 
Created attachment 32245 [details]
Use RGBColor::create in V8 bindings codegen

Patch to the V8 bindings codegenerator to correctly use RGBColor::create to create RGBColor objects.  This avoid memory leaks because of errors in refcounting.
Comment 1 Dimitri Glazkov (Google) 2009-07-04 09:12:50 PDT 
Would you consider upstreaming RGBColor bindings as well, since you're working in this area?
Comment 2 Dimitri Glazkov (Google) 2009-07-04 10:00:46 PDT 
Comment on attachment 32245 [details]
Use RGBColor::create in V8 bindings codegen

The change looks fine. I would really love to see the RGBColor upstreamed, though :)
Comment 3 Nate Chapin 2009-07-09 11:18:46 PDT 
Landed as r45666.
Comment 4 Adam Barth 2009-07-17 00:43:39 PDT 
This bug claims to have been landed.