WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26955
Use RGBColor::create in V8 bindings codegenerator
https://bugs.webkit.org/show_bug.cgi?id=26955
Summary
Use RGBColor::create in V8 bindings codegenerator
Mads Ager
Reported
2009-07-03 12:22:48 PDT
Created
attachment 32245
[details]
Use RGBColor::create in V8 bindings codegen Patch to the V8 bindings codegenerator to correctly use RGBColor::create to create RGBColor objects. This avoid memory leaks because of errors in refcounting.
Attachments
Use RGBColor::create in V8 bindings codegen
(5.57 KB, patch)
2009-07-03 12:22 PDT
,
Mads Ager
dglazkov
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-07-04 09:12:50 PDT
Would you consider upstreaming RGBColor bindings as well, since you're working in this area?
Dimitri Glazkov (Google)
Comment 2
2009-07-04 10:00:46 PDT
Comment on
attachment 32245
[details]
Use RGBColor::create in V8 bindings codegen The change looks fine. I would really love to see the RGBColor upstreamed, though :)
Nate Chapin
Comment 3
2009-07-09 11:18:46 PDT
Landed as
r45666
.
Adam Barth
Comment 4
2009-07-17 00:43:39 PDT
This bug claims to have been landed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug