RESOLVED FIXED269548
Adopt more smart pointers in AXObjectCache.cpp 
https://bugs.webkit.org/show_bug.cgi?id=269548
Summary Adopt more smart pointers in AXObjectCache.cpp
Chris Dumez
Reported 2024-02-15 21:53:46 PST
Adopt more smart pointers in AXObjectCache.cpp, as reported by the static analyzer.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-15 21:54:09 PST
<rdar://problem/123066225>
Chris Dumez
Comment 2 2024-02-15 21:55:50 PST
Pull request: https://github.com/WebKit/WebKit/pull/24582
EWS
Comment 3 2024-02-16 16:16:29 PST
Committed 274894@main (4c899d7a2ab1): <https://commits.webkit.org/274894@main> Reviewed commits have been landed. Closing PR #24582 and removing active labels.
Diego Pino
Comment 4 2024-02-19 03:55:19 PST
Debian Stable build bot is failing after this change: https://build.webkit.org/#/builders/46/builds/37636 ``` In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-1.cpp:7: ../../../Source/WebCore/accessibility/AXTextMarker.cpp: In member function ‘WebCore::AXTextMarker::operator WebCore::CharacterOffset() const’: ../../../Source/WebCore/accessibility/AXTextMarker.cpp:163:28: error: ‘auto’ parameter not permitted in this context 163 | CharacterOffset result(RefPtr { m_data.node }.get(), m_data.characterStart, m_data.characterOffset); | ^~~~~~ ```
Diego Pino
Comment 5 2024-02-19 03:56:36 PST
Re-opening for pull request https://github.com/webkit/webkit/pull/24734
EWS
Comment 6 2024-02-19 04:08:16 PST
Committed 274968@main (fe3079fddbfb): <https://commits.webkit.org/274968@main> Reviewed commits have been landed. Closing PR #24734 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.