Bug 269475 - 269988@main broke the ability to conditionally enable feature default values
Summary: 269988@main broke the ability to conditionally enable feature default values
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-15 09:54 PST by Mike Wyrzykowski
Modified: 2024-02-15 10:07 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2024-02-15 09:54:46 PST 
In UnifiedWebPreferences.yaml there are quite a few features with defaults like so:

    WebKit:
      "PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)": true
      default: false

however the 'status' category is tightly coupled to the feature definition and there is no obvious way to have multiple feature categories or have a status that is not aligned with its default value.

This is the case when ENABLE_FEATURE_DEFAULT_VALIDATION is 1 which only applies to macOS 14 and later.
Comment 1 Radar WebKit Bug Importer 2024-02-15 09:55:01 PST 
<rdar://problem/123020563>
Comment 2 Elliott Williams 2024-02-15 10:07:05 PST 
> however the 'status' category is tightly coupled to the feature definition and there is no obvious way to have multiple feature categories or have a status that is not aligned with its default value.

Yeah. I think it would be a good improvement to allow the status to be conditionally specified, i.e.

	status:
	   PLATFORM(IOS_FAMILY): stable
	   default: preview

For now, the status should correspond with the feature's availability on macOS, since that is where feature status is user-visible.