Bug 269338 - Devirtualize Event::eventInterface
Summary: Devirtualize Event::eventInterface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 269743
Blocks:
  Show dependency tree / graph
 
Reported: 2024-02-13 20:15 PST by Ryosuke Niwa
Modified: 2024-02-21 23:20 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2024-02-13 20:15:19 PST 
There is no need for it to be a virtual function call. We have plenty of space left to have it inlined into Event object itself.
Comment 1 Ryosuke Niwa 2024-02-13 22:06:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24399
Comment 2 EWS 2024-02-17 01:30:33 PST 
Committed 274913@main (bd2795436d8c): <https://commits.webkit.org/274913@main>

Reviewed commits have been landed. Closing PR #24399 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-02-17 01:31:14 PST 
<rdar://problem/123144696>
Comment 4 WebKit Commit Bot 2024-02-19 13:06:13 PST 
Re-opened since this is blocked by bug 269743
Comment 5 Ryosuke Niwa 2024-02-21 21:21:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24927
Comment 6 EWS 2024-02-21 23:20:10 PST 
Committed 275155@main (8b36ea3d233a): <https://commits.webkit.org/275155@main>

Reviewed commits have been landed. Closing PR #24927 and removing active labels.