RESOLVED FIXED 269334
HTMLMediaElement::player() shouldn't return a RefPtr 
https://bugs.webkit.org/show_bug.cgi?id=269334
Summary HTMLMediaElement::player() shouldn't return a RefPtr
Chris Dumez
Reported 2024-02-13 16:32:46 PST
HTMLMediaElement::player() shouldn't return a RefPtr as it causes unnecessary ref-counting churn for call sites that don't need it. Instead, follow the usual pattern: 1. Have HTMLMediaElement::player() return a raw pointer 2. Introduce a HTMLMediaElement::protectedPlayer() which returns a RefPtr for the call sites that need a RefPtr
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2024-02-13 16:34:45 PST
Pull request: https://github.com/WebKit/WebKit/pull/24384
EWS
Comment 2 2024-02-13 19:40:26 PST
Committed 274601@main (805716af7882): <https://commits.webkit.org/274601@main> Reviewed commits have been landed. Closing PR #24384 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-02-13 19:41:18 PST
<rdar://problem/122927456>
Note You need to log in before you can comment on or make changes to this bug.