RESOLVED FIXED269331
Element::userAgentShadowRoot() shouldn't return a RefPtr 
https://bugs.webkit.org/show_bug.cgi?id=269331
Summary Element::userAgentShadowRoot() shouldn't return a RefPtr
Chris Dumez
Reported 2024-02-13 16:16:30 PST
Element::userAgentShadowRoot() shouldn't return a RefPtr. It causes unnecessary ref-counting churn for caller that don't need it. Have it return a raw pointer instead and add a `protectedUserAgentShadowRoot()` getter for the callers that actually want a RefPtr.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2024-02-13 16:21:08 PST
Pull request: https://github.com/WebKit/WebKit/pull/24382
EWS
Comment 2 2024-02-13 19:43:40 PST
Committed 274602@main (9951fe460428): <https://commits.webkit.org/274602@main> Reviewed commits have been landed. Closing PR #24382 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-02-13 19:44:24 PST
<rdar://problem/122927497>
Note You need to log in before you can comment on or make changes to this bug.