RESOLVED FIXED 26929
convertFromScrollbarToContainingView and friends should be in ScrollView 
https://bugs.webkit.org/show_bug.cgi?id=26929
Summary convertFromScrollbarToContainingView and friends should be in ScrollView
Jeremy Orlow
Reported 2009-07-02 12:38:15 PDT
convertFromScrollbarToContainingView and friends should be in ScrollView (but still overridable) This is breaking Chromium's build because PopupMenuChromium inherits from ScrollView, but these functions are pure virtual in it. I could put it directly in PopupMenuChromium, but that seems a bit silly since the functions are fairly generic.
Attachments
patch (6.85 KB, patch)
2009-07-02 12:52 PDT, Jeremy Orlow 		simon.fraser: review+
DetailsFormatted DiffDiff
Remove unused functions (3.76 KB, patch)
2009-07-02 13:13 PDT, Dave Hyatt 		simon.fraser: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-07-02 12:52:59 PDT
Created attachment 32191 [details] patch
Dave Hyatt
Comment 2 2009-07-02 12:59:37 PDT
Comment on attachment 32191 [details] patch Remove the FIXME: Test on Windows. I forgot to do that. Oops. You can devirtualize the methods once you move them to ScrollView.
Dave Hyatt
Comment 3 2009-07-02 13:13:22 PDT
Created attachment 32194 [details] Remove unused functions
Simon Fraser (smfr)
Comment 4 2009-07-02 13:16:58 PDT
Comment on attachment 32194 [details] Remove unused functions The previous patch is right.
Simon Fraser (smfr)
Comment 5 2009-07-02 13:17:10 PDT
Comment on attachment 32191 [details] patch This is the right one!
Dave Hyatt
Comment 6 2009-07-02 13:19:13 PDT
Fixed in r45485.
Note You need to log in before you can comment on or make changes to this bug.