Bug 26929 - convertFromScrollbarToContainingView and friends should be in ScrollView
Summary: convertFromScrollbarToContainingView and friends should be in ScrollView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-02 12:38 PDT by Jeremy Orlow
Modified: 2009-07-02 13:19 PDT (History)
1 user (show)

See Also:

Attachments
patch (6.85 KB, patch)
2009-07-02 12:52 PDT, Jeremy Orlow 		simon.fraser: review+
Details | Formatted Diff | Diff
Remove unused functions (3.76 KB, patch)
2009-07-02 13:13 PDT, Dave Hyatt 		simon.fraser: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-07-02 12:38:15 PDT 
convertFromScrollbarToContainingView and friends should be in ScrollView (but still overridable)

This is breaking Chromium's build because PopupMenuChromium inherits from ScrollView, but these functions are pure virtual in it.  I could put it directly in PopupMenuChromium, but that seems a bit silly since the functions are fairly generic.
Comment 1 Jeremy Orlow 2009-07-02 12:52:59 PDT 
Created attachment 32191 [details]
patch
Comment 2 Dave Hyatt 2009-07-02 12:59:37 PDT 
Comment on attachment 32191 [details]
patch

Remove the FIXME: Test on Windows.  I forgot to do that. Oops.

You can devirtualize the methods once you move them to ScrollView.
Comment 3 Dave Hyatt 2009-07-02 13:13:22 PDT 
Created attachment 32194 [details]
Remove unused functions
Comment 4 Simon Fraser (smfr) 2009-07-02 13:16:58 PDT 
Comment on attachment 32194 [details]
Remove unused functions

The previous patch is right.
Comment 5 Simon Fraser (smfr) 2009-07-02 13:17:10 PDT 
Comment on attachment 32191 [details]
patch

This is the right one!
Comment 6 Dave Hyatt 2009-07-02 13:19:13 PDT 
Fixed in r45485.