Bug 269240 – REGRESSION (274152@main?): [ iOS17 Monterey+ Debug ] Multiple API tests in TestWebKitAPI.WKDownload are constant ASSERT.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Marta Darbinyan]

Description:
TestWebKitAPI.WKDownload.CancelAndResume
TestWebKitAPI.DownloadProgress.StartDownloadInProcessPool
TestWebKitAPI.URLSchemeHandler.Frames
TestWebKitAPI.WKDownload.BlobDownload 
TestWebKitAPI.WKDownload.ChallengeFailure
TestWebKitAPI.WKDownload.ChallengeSuccess
TestWebKitAPI.WKDownload.DownloadRequest404
TestWebKitAPI.WKDownload.FailAndResume
TestWebKitAPI.WKDownload.InvalidArguments
TestWebKitAPI.WKDownload.RedirectAllow
TestWebKitAPI.WKDownload.RedirectCancel
TestWebKitAPI.WKDownload.RequestHTTPBody
TestWebKitAPI.WKDownload.ResumeCantReconnect
TestWebKitAPI.WKDownload.ResumeWithExtraInitialDataOnDisk
TestWebKitAPI.WKDownload.ResumeWithoutInitialDataOnDisk
TestWebKitAPI.WebKit.ContextMenuDownloadHTMLDownloadAttribute
TestWebKitAPI.WebKit.ContextMenuDownloadHTMLDownloadAttributeWithSlashes
TestWebKitAPI._WKDownload.Resume
TestWebKitAPI._WKDownload.ResumedDownloadCanHandleAuthenticationChallenge

Are consistent crash in iOS17 and macOS Monetery+ Debug. Suspecting the commit 274152@main that had frame identifier updates..

Result:
ASSERTION FAILED: m_data.frameID.object().isValid()
        /Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/Source/WebKit/UIProcess/API/APIFrameInfo.cpp(46) : API::FrameInfo::FrameInfo(WebKit::FrameInfoData &&, RefPtr<WebKit::WebPageProxy> &&)
        1   0x124c1c949 WTFCrash
        2   0x19d7434cb WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x19f8467ce API::FrameInfo::FrameInfo(WebKit::FrameInfoData&&, WTF::RefPtr<WebKit::WebPageProxy, WTF::RawPtrTraits<WebKit::WebPageProxy>, WTF::DefaultRefDerefTraits<WebKit::WebPageProxy>>&&)
        4   0x19f846705 API::FrameInfo::FrameInfo(WebKit::FrameInfoData&&, WTF::RefPtr<WebKit::WebPageProxy, WTF::RawPtrTraits<WebKit::WebPageProxy>, WTF::DefaultRefDerefTraits<WebKit::WebPageProxy>>&&)
        5   0x19f84665d API::FrameInfo::create(WebKit::FrameInfoData&&, WTF::RefPtr<WebKit::WebPageProxy, WTF::RawPtrTraits<WebKit::WebPageProxy>, WTF::DefaultRefDerefTraits<WebKit::WebPageProxy>>&&)
        6   0x19f8d0add WebKit::DownloadProxy::DownloadProxy(WebKit::DownloadProxyMap&, WebKit::WebsiteDataStore&, API::DownloadClient&, WebCore::ResourceRequest const&, WebKit::FrameInfoData const&, WebKit::WebPageProxy*)
        7   0x19f8d0c79 WebKit::DownloadProxy::DownloadProxy(WebKit::DownloadProxyMap&, WebKit::WebsiteDataStore&, API::DownloadClient&, WebCore::ResourceRequest const&, WebKit::FrameInfoData const&, WebKit::WebPageProxy*)
        8   0x19f8d2e7d WTF::Ref<WebKit::DownloadProxy, WTF::RawPtrTraits<WebKit::DownloadProxy>, WTF::DefaultRefDerefTraits<WebKit::DownloadProxy>> WebKit::DownloadProxy::create<WebKit::DownloadProxyMap&, WebKit::WebsiteDataStore&, WTF::Ref<API::DownloadClient, WTF::RawPtrTraits<API::DownloadClient>, WTF::DefaultRefDerefTraits<API::DownloadClient>>, WebCore::ResourceRequest const&, WebKit::FrameInfoData const&, WebKit::WebPageProxy*&>(WebKit::DownloadProxyMap&, WebKit::WebsiteDataStore&, WTF::Ref<API::DownloadClient, WTF::RawPtrTraits<API::DownloadClient>, WTF::DefaultRefDerefTraits<API::DownloadClient>>&&, WebCore::ResourceRequest const&, WebKit::FrameInfoData const&, WebKit::WebPageProxy*&)
        9   0x19f8d2862 WebKit::DownloadProxyMap::createDownloadProxy(WebKit::WebsiteDataStore&, WTF::Ref<API::DownloadClient, WTF::RawPtrTraits<API::DownloadClient>, WTF::DefaultRefDerefTraits<API::DownloadClient>>&&, WebCore::ResourceRequest const&, WebKit::FrameInfoData const&, WebKit::WebPageProxy*)
        10  0x19f960209 WebKit::NetworkProcessProxy::createDownloadProxy(WebKit::WebsiteDataStore&, WTF::Ref<API::DownloadClient, WTF::RawPtrTraits<API::DownloadClient>, WTF::DefaultRefDerefTraits<API::DownloadClient>>&&, WebCore::ResourceRequest const&, WebKit::FrameInfoData const&, WebKit::WebPageProxy*)
        11  0x19fa49159 WebKit::WebsiteDataStore::createDownloadProxy(WTF::Ref<API::DownloadClient, WTF::RawPtrTraits<API::DownloadClient>, WTF::DefaultRefDerefTraits<API::DownloadClient>>&&, WebCore::ResourceRequest const&, WebKit::WebPageProxy*, WebKit::FrameInfoData const&)
        12  0x19f60453d WebKit::WebProcessPool::createDownloadProxy(WebKit::WebsiteDataStore&, WebCore::ResourceRequest const&, WebKit::WebPageProxy*, WebKit::FrameInfoData const&)
        13  0x19f6250e2 WebKit::WebProcessPool::resumeDownload(WebKit::WebsiteDataStore&, WebKit::WebPageProxy*, API::Data const&, WTF::String const&, WebKit::CallDownloadDidStart)
        14  0x19ead1ff6 -[WKProcessPool(WKPrivate) _resumeDownloadFromData:websiteDataStore:path:originatingWebView:]
        15  0x10e592baf _WKDownload_Resume_Test::TestBody()
        16  0x10f13353b void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        17  0x10f0eaf3a void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        18  0x10f0eae83 testing::Test::Run()
        19  0x10f0ebfb1 testing::TestInfo::Run()
        20  0x10f0ed054 testing::TestSuite::Run()
        21  0x10f0fc25b testing::internal::UnitTestImpl::RunAllTests()
        22  0x10f133ddb bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        23  0x10f0fbc1a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        24  0x10f0fbb05 testing::UnitTest::Run()
        25  0x10e4684f1 RUN_ALL_TESTS()
        26  0x10e468486 TestWebKitAPI::TestsController::run(int, char**)
        27  0x10f0badb3 main
        28  0x7ff80bdd5386 start


History:
https://results.webkit.org/?style=debug&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.DownloadProgress.StartDownloadInProcessPool&test=TestWebKitAPI.URLSchemeHandler.Frames&test=TestWebKitAPI.WKDownload.BlobDownload&test=TestWebKitAPI.WKDownload.CancelAndResume&test=TestWebKitAPI.WKDownload.ChallengeFailure&test=TestWebKitAPI.WKDownload.ChallengeSuccess&test=TestWebKitAPI.WKDownload.DownloadRequest404&test=TestWebKitAPI.WKDownload.FailAndResume&test=TestWebKitAPI.WKDownload.InvalidArguments&test=TestWebKitAPI.WKDownload.RedirectAllow&test=TestWebKitAPI.WKDownload.RedirectCancel&test=TestWebKitAPI.WKDownload.RequestHTTPBody&test=TestWebKitAPI.WKDownload.ResumeCantReconnect&test=TestWebKitAPI.WKDownload.ResumeWithExtraInitialDataOnDisk&test=TestWebKitAPI.WKDownload.ResumeWithoutInitialDataOnDisk&test=TestWebKitAPI.WebKit.ContextMenuDownloadHTMLDownloadAttribute&test=TestWebKitAPI.WebKit.ContextMenuDownloadHTMLDownloadAttributeWithSlashes&test=TestWebKitAPI._WKDownload.Resume&test=TestWebKitAPI._WKDownload.ResumedDownloadCanHandleAuthenticationChallenge


Link:
https://build.webkit.org/#/builders/933/builds/918/steps/19/logs/stdio

[Radar WebKit Bug Importer]

<rdar://problem/122831039>

[Marta Darbinyan]

Pull request: https://github.com/WebKit/WebKit/pull/24354

[EWS]

Committed 274564@main (7dbe9729bdea): <https://commits.webkit.org/274564@main>

Reviewed commits have been landed. Closing PR #24354 and removing active labels.