Bug 269190 - [Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff
Summary: [Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: InRadar
Depends on:
Blocks: GLibSkia
  Show dependency tree / graph
 
Reported: 2024-02-12 06:49 PST by Adrian Perez
Modified: 2024-02-14 05:46 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2024-02-12 06:49:31 PST 
Developer builds with USE_SKIA=ON still check for Cairo:

  -- Found Cairo: /usr/lib/x86_64-linux-gnu/libcairo.so (found version "1.18.0")

This is still used by Tools/ImageDiff/ --  we should make it use
Skia as well.
Comment 1 Carlos Garcia Campos 2024-02-12 07:15:43 PST 
Do we even use ImageDiff nowadays?
Comment 2 Fujii Hironori 2024-02-12 11:52:47 PST 
Yes, ref tests are using ImageDiff.
Comment 3 Carlos Garcia Campos 2024-02-13 02:54:12 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24333
Comment 4 EWS 2024-02-13 05:44:38 PST 
Committed 274544@main (0e6f0245ab8d): <https://commits.webkit.org/274544@main>

Reviewed commits have been landed. Closing PR #24333 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2024-02-13 05:45:58 PST 
<rdar://problem/122868769>