RESOLVED FIXED 269190
[Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff 
https://bugs.webkit.org/show_bug.cgi?id=269190
Summary [Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff
Adrian Perez
Reported 2024-02-12 06:49:31 PST
Developer builds with USE_SKIA=ON still check for Cairo: -- Found Cairo: /usr/lib/x86_64-linux-gnu/libcairo.so (found version "1.18.0") This is still used by Tools/ImageDiff/ -- we should make it use Skia as well.
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2024-02-12 07:15:43 PST
Do we even use ImageDiff nowadays?
Fujii Hironori
Comment 2 2024-02-12 11:52:47 PST
Yes, ref tests are using ImageDiff.
Carlos Garcia Campos
Comment 3 2024-02-13 02:54:12 PST
Pull request: https://github.com/WebKit/WebKit/pull/24333
EWS
Comment 4 2024-02-13 05:44:38 PST
Committed 274544@main (0e6f0245ab8d): <https://commits.webkit.org/274544@main> Reviewed commits have been landed. Closing PR #24333 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2024-02-13 05:45:58 PST
<rdar://problem/122868769>
Note You need to log in before you can comment on or make changes to this bug.