RESOLVED FIXED 269165
[Digital Identity]: navigator.identity should be implemented by a separate IdentityCredentialManager 
https://bugs.webkit.org/show_bug.cgi?id=269165
Summary [Digital Identity]: navigator.identity should be implemented by a separate Id...
Marcos Caceres
Reported 2024-02-11 03:47:49 PST
Once bug 268516 is in place, we need to implement an IdentityCredentialManager class that inherits from CredentialManager. My idea is to make the methods on CredentialManager all virtual, so to allow IdentityCredentialManager to override them. At the same time, we want to have shared error checking behavior in both IdentityCredentialManager and CredentialManager, so need to make sure that we split those checks out.
Attachments
Add attachment proposed patch, testcase, etc.
Marcos Caceres
Comment 1 2024-02-11 03:49:01 PST
I mean, once 268726 is in place instead.
Radar WebKit Bug Importer
Comment 2 2024-02-18 03:48:13 PST
<rdar://problem/123184696>
Marcos Caceres
Comment 3 2024-02-29 23:16:39 PST
Pull request: https://github.com/WebKit/WebKit/pull/25338
EWS
Comment 4 2024-03-11 16:35:01 PDT
Committed 275939@main (2dbfef33bb52): <https://commits.webkit.org/275939@main> Reviewed commits have been landed. Closing PR #25338 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.