RESOLVED FIXED Bug 26916
bugzilla-tool needs scm unit tests 
https://bugs.webkit.org/show_bug.cgi?id=26916
Summary bugzilla-tool needs scm unit tests
Eric Seidel (no email)
Reported 2009-07-01 22:12:17 PDT
bugzilla-tool needs PyUnit testing. Desperately. I looked at this a little the other day. I found that PyUnit (unitest module) uses a code style which does not conform to modern python style guides. This was very confusing, but shouldn't block me using it. I searched the web a little and did not find any guidance on the matter. git cl (a similar tool which Chromium uses) has a whole set of test suites: http://neugierig.org/software/git/?url=git-cl/tree/test but they're bash files... which is also kinda nasty. (elegant, but nasty).
Attachments
Patch v1 (7.04 KB, patch)
2009-08-04 11:58 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-08-04 09:18:04 PDT
I've added a few tests. I'll keep this around for adding the scm_unittest.py (which are the tricky ones).
Eric Seidel (no email)
Comment 2 2009-08-04 11:58:04 PDT
Created attachment 34078 [details] Patch v1
Eric Seidel (no email)
Comment 3 2009-08-04 12:08:37 PDT
I've broken off the bugzilla bits into bug 27991.
Adam Barth
Comment 4 2009-08-04 12:10:49 PDT
Comment on attachment 34078 [details] Patch v1 This looks like a good start. We'll need to do more eventually, but I like the idea of building a fake repo in the tmp directory.
Eric Seidel (no email)
Comment 5 2009-08-04 12:18:14 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/scm.py A WebKitTools/Scripts/modules/scm_unittest.py Committed r46772 M WebKitTools/ChangeLog A WebKitTools/Scripts/modules/scm_unittest.py M WebKitTools/Scripts/modules/scm.py r46772 = 2216d9a41da59a3e65c137e9fdd39b75776a7286 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46772
Note You need to log in before you can comment on or make changes to this bug.