Bug 26913 – bugzilla-tool needs to handle login failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

bugzilla-tool needs to handle login failure

Right now bugzilla-tool will probably silently fail if you type your bugzilla credentials wrong.

Need to fix that.  The offending code can be found in Bugzilla.authenticate()

[Eric Seidel (no email)]

Created attachment 32204 [details]
patch

[Eric Seidel (no email)]

Hopefully this will solve Ojan's issue with the tool.  It was failing silently for him.  I confirmed (when fixing this) that failing to authenticate would cause silent failure.

[David Levin]

Comment on attachment 32204 [details]
patch


> diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py
> +        match = re.search("<title>(.+)</title>", response.read())

You could do a non-greedy match here like this "<title>(.+?)</title>" (which would be more typical for grabbing the context of just one tag) but it isn't necessary here.

[Eric Seidel (no email)]

Yeah, I wondered if I shouldn't make it non-greedy.  Will fix and land.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
	M	WebKitTools/Scripts/modules/scm.py
Committed r45507
	M	WebCore/editing/TextIterator.cpp
	M	WebCore/ChangeLog
r45506 = 55478c55c76eed28de6cfeca788a16c4604e8a02 (trunk)
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
	M	WebKitTools/Scripts/modules/scm.py
r45507 = fad7ccb51023dad4d4b09407360f769d77de38df (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/45507

[Eric Seidel (no email)]

Ojan: please give the tool another try when you get a chance. :)