Bug 269107 – Need reminder/warning about updating IPC serialization tests when modifying certain files

• Status: NEW
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

WebKit needs a reminder or warning about updating IPC serialization tests when modifying certain files:

    Source/WebKit/Scripts/generate-serializers.py
    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h
    Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp
    Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in

Basically, we want to remind when there is a change to these files:

    Source/WebKit/Scripts/generate-serializers.py
    Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in

But no change to these files:

    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h
    Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp

There are various ways to do this, so I'm not trying to prescribe a specific solution in the Description.

[David Kilzer (:ddkilzer)]

Created attachment 469801 [details]
Patch to implement watchlist in git-webkit pre-pr step

[David Kilzer (:ddkilzer)]

Alex didn't like this being implemented in `git-webkit pr` (thought it was too early?), but would prefer to have it happen on the EWS bots.

I don't have time to implement that now, but I attached my initial patch for inspiration in case anyone wants to pick this up.

[EWS Watchlist]

Reminder: run `make -C Source/WebKit/Scripts/webkit/tests` after adding tests to TestSerializedType.serialization.in or modifying generate-serializers.py.

[Radar WebKit Bug Importer]

<rdar://problem/123119260>