Bug 269107 - Need reminder/warning about updating IPC serialization tests when modifying certain files
Summary: Need reminder/warning about updating IPC serialization tests when modifying c...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-09 15:41 PST by David Kilzer (:ddkilzer)
Modified: 2024-02-16 15:42 PST (History)
6 users (show)

See Also:

Attachments
Patch to implement watchlist in git-webkit pre-pr step (10.65 KB, patch)
2024-02-09 15:42 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2024-02-09 15:41:12 PST 
WebKit needs a reminder or warning about updating IPC serialization tests when modifying certain files:

    Source/WebKit/Scripts/generate-serializers.py
    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h
    Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp
    Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in

Basically, we want to remind when there is a change to these files:

    Source/WebKit/Scripts/generate-serializers.py
    Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in

But no change to these files:

    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h
    Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp

There are various ways to do this, so I'm not trying to prescribe a specific solution in the Description.
Comment 1 David Kilzer (:ddkilzer) 2024-02-09 15:42:49 PST 
Created attachment 469801 [details]
Patch to implement watchlist in git-webkit pre-pr step
Comment 2 David Kilzer (:ddkilzer) 2024-02-09 15:46:12 PST 
Alex didn't like this being implemented in `git-webkit pr` (thought it was too early?), but would prefer to have it happen on the EWS bots.

I don't have time to implement that now, but I attached my initial patch for inspiration in case anyone wants to pick this up.
Comment 3 EWS Watchlist 2024-02-09 15:53:55 PST 
Reminder: run `make -C Source/WebKit/Scripts/webkit/tests` after adding tests to TestSerializedType.serialization.in or modifying generate-serializers.py.
Comment 4 Radar WebKit Bug Importer 2024-02-16 15:42:13 PST 
<rdar://problem/123119260>