Bug 269034 - [ews-build.webkit.org] Handle duplicate GitHub hooks
Summary: [ews-build.webkit.org] Handle duplicate GitHub hooks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-08 17:01 PST by Jonathan Bedard
Modified: 2024-02-09 11:08 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2024-02-08 17:01:35 PST 
Occasionally, GitHub will send duplicate hooks. ews-build.webkit.org, in particular, should handle such duplicates. Note that in practice, these duplicates are very close together in time, and in general, we want to process duplicate build requests if they are sufficiently far apart (like an engineer re-adding merge-queue an hour after automation remove the label, for example).
Comment 1 Jonathan Bedard 2024-02-08 17:01:53 PST 
<rdar://problem/122589894>
Comment 2 Jonathan Bedard 2024-02-08 17:05:27 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24112
Comment 3 EWS 2024-02-09 09:15:04 PST 
Committed 274369@main (a2343bf6a44c): <https://commits.webkit.org/274369@main>

Reviewed commits have been landed. Closing PR #24112 and removing active labels.
Comment 4 Jonathan Bedard 2024-02-09 10:58:42 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/24158
Comment 5 EWS 2024-02-09 11:08:17 PST 
Committed 274377@main (9ca954b0571e): <https://commits.webkit.org/274377@main>

Reviewed commits have been landed. Closing PR #24158 and removing active labels.