AX: Input time element field labels and values are not spoken by VoiceOver.

[Andres Gonzalez]

.

[Radar WebKit Bug Importer]

<rdar://problem/122590568>

[Andres Gonzalez]

Created attachment 469783 [details]
Patch

[Tyler Wilcock]

Comment on attachment 469783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469783&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:794
> +        RefPtr input = dynamicDowncast<HTMLInputElement>(node());
> +        if (input)
> +            return input->visibleValue();

Can this be:

if (RefPtr input = dynamicDowncast<HTMLInputElement>(node()))
    return input->visibleValue();

I notice that we never update AXPropertyName::StringValue, and I'm wondering if we need to make sure to keep it up-to-date when HTMLInputElement::visibleValue() changes. Not sure if this is a problem in practice though?

[Andres Gonzalez]

Created attachment 469788 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 469783 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=469783&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:794
> > +        RefPtr input = dynamicDowncast<HTMLInputElement>(node());
> > +        if (input)
> > +            return input->visibleValue();
> 
> Can this be:
> 
> if (RefPtr input = dynamicDowncast<HTMLInputElement>(node()))
>     return input->visibleValue();

Fixed.

> 
> I notice that we never update AXPropertyName::StringValue, and I'm wondering
> if we need to make sure to keep it up-to-date when
> HTMLInputElement::visibleValue() changes. Not sure if this is a problem in
> practice though?

We do fire a number of AXValueChanged and in updateIsolatedTree we do

        case AXValueChanged:
            updateNode(notification.first);

We could probably be more surgical and try to update only the value related properties. In any case, it is not a problem for datetimes, either because we are getting an AXValueChanged or maybe a ChildrenChanged.

[Andres Gonzalez]

Created attachment 469807 [details]
Patch

[chris fleizach]

Comment on attachment 469807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469807&action=review

> COMMIT_MESSAGE:7
> +VoiceOver does not speak the value of <input type="time">, and does not announces the value of individual fields within the control when neigher a field is selected nor its value changed. This patch fixes these problem for numeric fields (derived from DateTimeNumericFieldElement) by providing appropriate labels for those fields and a role of SpinButton. In addition, AccessibilityRenderObject::stringValue now returns the correct value for all variants of date and time elements.

neigher -> spelling

[Andres Gonzalez]

Created attachment 469984 [details]
Patch

[Andres Gonzalez]

Created attachment 470040 [details]
Patch

[Andres Gonzalez]

Created attachment 470043 [details]
Patch

Update Monterey expectation.

[EWS]

Committed 275301@main (4a4b6fe780e4): <https://commits.webkit.org/275301@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 470043 [details].