WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
269001
Adopt more smart pointers for SVGDocumentExtensions
https://bugs.webkit.org/show_bug.cgi?id=269001
Summary
Adopt more smart pointers for SVGDocumentExtensions
Chris Dumez
Reported
2024-02-08 10:24:24 PST
Adopt more smart pointers for SVGDocumentExtensions: 1. Rename `Document::svgExtensions()` to `Document::svgExtensionsIfExists()` and `Document::accessSVGExtensions()` to `Document::svgExtensions()` for consistency with our usual naming conventions. 2. Introduce `Document::checkedSVGExtensions()` which returns a `CheckedRef<>` and adopt where appropriate. 3. Update call site to make sure the `Document` is protected during the scope of the SVGDocumentExtensions variable, since it owns it.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2024-02-08 10:27:18 PST
Pull request:
https://github.com/WebKit/WebKit/pull/24085
EWS
Comment 2
2024-02-08 14:51:44 PST
Committed
274316@main
(dccc78696b92): <
https://commits.webkit.org/274316@main
> Reviewed commits have been landed. Closing PR #24085 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-02-08 14:52:31 PST
<
rdar://problem/122584885
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug