Bug 269001 - Adopt more smart pointers for SVGDocumentExtensions
Summary: Adopt more smart pointers for SVGDocumentExtensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-02-08 10:24 PST by Chris Dumez
Modified: 2024-02-08 14:52 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2024-02-08 10:24:24 PST 
Adopt more smart pointers for SVGDocumentExtensions:
1. Rename `Document::svgExtensions()` to `Document::svgExtensionsIfExists()` and `Document::accessSVGExtensions()` to `Document::svgExtensions()` for consistency with our usual naming conventions.
2. Introduce `Document::checkedSVGExtensions()` which returns a `CheckedRef<>` and adopt where appropriate.
3. Update call site to make sure the `Document` is protected during the scope of the SVGDocumentExtensions variable, since it owns it.
Comment 1 Chris Dumez 2024-02-08 10:27:18 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24085
Comment 2 EWS 2024-02-08 14:51:44 PST 
Committed 274316@main (dccc78696b92): <https://commits.webkit.org/274316@main>

Reviewed commits have been landed. Closing PR #24085 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-02-08 14:52:31 PST 
<rdar://problem/122584885>