Bug 26900 – AX: Manual spell check with Command-; does not bring up suggestions

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Manual spell check with Command-; whilst finding the mis spelled word does not bring up suggestions within the context menu.
When on a mis spelled word with command-;, pressing Vo-Shift-M for the context menu does not result in any suggestions within the menu.

[chris fleizach]

Created attachment 32142 [details]
patch

[Beth Dakin]

Comment on attachment 32142 [details]
patch

> +IntPoint AccessibilityRenderObject::clickPoint() const
> +{
> +    // if we're asked to perform a show menu on an editable web area,
> +    // the click point should be where the selection is
> +    if (isWebArea() && !isReadOnly()) {
> +        VisibleSelection visSelection = selection();
> +        VisiblePositionRange range = VisiblePositionRange(visSelection.visibleStart(), visSelection.visibleEnd());
> +        IntRect bounds = boundsForVisiblePositionRange(range);
> +#if PLATFORM(MAC)
> +        bounds.setLocation(m_renderer->document()->view()->screenToContents(bounds.location()));
> +#endif        
> +        return IntPoint(bounds.x() + (bounds.width() / 2), bounds.y() - (bounds.height() / 2));
> +    }
> +
> +    return AccessibilityObject::clickPoint();
> +}

This is just a style nit-pick, but how about you do the generic case as an early return like:

if (!isWebArea() || isReadOnly())
    return AccessibilityObject::clickPoint();

VisibleSelection visSelection = selection();
…




r=me!

[chris fleizach]

will fix...

[chris fleizach]

http://trac.webkit.org/changeset/45452