RESOLVED FIXED 268962
[Perf Dashboard] AsyncTaskWorker is buggy 
https://bugs.webkit.org/show_bug.cgi?id=268962
Summary [Perf Dashboard] AsyncTaskWorker is buggy
Ryosuke Niwa
Reported 2024-02-07 20:36:54 PST
AsyncTaskWorker has two bugs: 1. waitForAvailableWorker is pushing callback while it finds an available worker. This does not make sense since we will invoke this callback twice. 2. This setTimeout code is assuming that, after the wait, there is still a callback in the queue. But this is not guaranteed since worker will continuously consume tasks from queue. So if the other workers are finishing their task, and consume next one, and if it gets exhausted when executing this setTimeout's task, then we hit an error
Attachments
Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2024-02-07 20:39:48 PST
<rdar://problem/121879117>
Yusuke Suzuki
Comment 2 2024-02-07 20:41:29 PST
Pull request: https://github.com/WebKit/WebKit/pull/24053
EWS
Comment 3 2024-02-07 20:57:38 PST
Committed 274265@main (dde5760b8dbf): <https://commits.webkit.org/274265@main> Reviewed commits have been landed. Closing PR #24053 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.